Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 5, 2025

Link issues

fixes #6823

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Ensure that visible columns are properly reset when calling ResetVisibleColumns on a resizable table

Bug Fixes:

Copilot AI review requested due to automatic review settings October 5, 2025 07:02
@bb-auto bb-auto bot added the bug Something isn't working label Oct 5, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where table columns were not being properly reset after calling ResetVisibleColumns when column resizing is enabled. The fix ensures that the _resetColumns flag is set to true when AllowResizing is enabled, which triggers the necessary column reset behavior.

  • Added conditional logic to set _resetColumns = true when AllowResizing is enabled
  • Updated version number from 9.11.1-beta03 to 9.11.1-beta04

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor/Components/Table/Table.razor.cs Added logic to set _resetColumns flag when AllowResizing is enabled in ResetVisibleColumns method
src/BootstrapBlazor/BootstrapBlazor.csproj Updated version number to 9.11.1-beta04

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhanced the ResetVisibleColumns method to include a resizing-aware reset flag, ensuring that when column resizing is enabled, a full column reset is triggered and the UI updates accordingly.

Sequence diagram for ResetVisibleColumns with resizing-aware reset

sequenceDiagram
participant TableComponent
participant UI
TableComponent->>TableComponent: ResetVisibleColumns(columns)
alt AllowResizing is true
    TableComponent->>TableComponent: _resetColumns = true
end
TableComponent->>TableComponent: InternalResetVisibleColumns(Columns, columns)
TableComponent->>UI: StateHasChanged()
Loading

Class diagram for Table component changes

classDiagram
class TableComponent {
  +bool AllowResizing
  +bool _resetColumns
  +void ResetVisibleColumns(IEnumerable<ColumnVisibleItem> columns)
  -void InternalResetVisibleColumns(List<ITableColumn> columns, IEnumerable<ColumnVisibleItem> columns)
}
TableComponent : ResetVisibleColumns() --> InternalResetVisibleColumns()
Loading

File-Level Changes

Change Details Files
Add resizing-aware reset logic in ResetVisibleColumns
  • Check if AllowResizing is true
  • Set private field _resetColumns to true
  • Invoke InternalResetVisibleColumns and call StateHasChanged
src/BootstrapBlazor/Components/Table/Table.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6823 Fix the bug where columns shown via ResetVisibleColumns cannot be resized when AllowResizing is true.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit cd4fc41 into main Oct 5, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch October 5, 2025 07:03
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.98%. Comparing base (59ec335) to head (a8c2de3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/BootstrapBlazor/Components/Table/Table.razor.cs 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #6828      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          739      739              
  Lines        31751    31755       +4     
  Branches      4465     4466       +1     
===========================================
  Hits         31751    31751              
- Misses           0        3       +3     
- Partials         0        1       +1     
Flag Coverage Δ
BB 99.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): 设置AllowResizing后 通过ResetVisibleColumns显示的列无法调整列宽度

2 participants